Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new QNAP Cinder storage backend implementation to Sunbeam and wires it into the unit-test backend matrix so it’s discovered and validated consistently with existing backends.
Changes:
- Introduce
QnapBackendandQnapConfig(including secret-marked credential fields and protocol validation). - Add QNAP-specific unit tests and extend common backend tests to include the new backend.
- Extend backend test fixtures to provide
qnap_backendand include it in the parametrizedany_backendfixture.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/qnap/backend.py |
Implements the QNAP backend and its Pydantic config model. |
sunbeam-python/sunbeam/storage/backends/qnap/__init__.py |
Adds the QNAP backend package module. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_qnap.py |
Adds unit tests validating QNAP backend identity, config shape, secret fields, and protocol validation. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Registers a qnap_backend fixture and adds QNAP to the shared backend parametrization. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Ensures QNAP participates in backend uniqueness checks and expected-type/charm-name assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/genearte-qnap-charm
branch
from
6ecf153 to
96038c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984513